Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[continuous-deploy-fingerprint] Add platform as input #280

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

NoZiL
Copy link
Contributor

@NoZiL NoZiL commented Apr 26, 2024

Playing with the new action for sdk 51, I've noticed that the platform is missing.
This is an attempt to handle this case.

Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the readme as well?

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition! Just a few stylistic changes, then I'll merge!

src/actions/continuous-deploy-fingerprint.ts Outdated Show resolved Hide resolved
src/actions/continuous-deploy-fingerprint.ts Outdated Show resolved Hide resolved
src/actions/continuous-deploy-fingerprint.ts Outdated Show resolved Hide resolved
src/actions/continuous-deploy-fingerprint.ts Outdated Show resolved Hide resolved
src/actions/continuous-deploy-fingerprint.ts Outdated Show resolved Hide resolved
src/actions/continuous-deploy-fingerprint.ts Outdated Show resolved Hide resolved
@NoZiL
Copy link
Contributor Author

NoZiL commented Sep 24, 2024

Hey @brentvatne, I added the input in the readme, tell me if something else needs to be added.
Hey @wschurman, sorry for the delay, I've dealt with the conflicts and added your suggestions. I also added the strict null checks in tsconfig to lint accordingly.

@wschurman wschurman self-requested a review September 24, 2024 17:10
@wschurman wschurman merged commit 6c50f92 into expo:main Sep 24, 2024
13 of 14 checks passed
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants