Skip to content

Commit

Permalink
fix: add codegen native component as external
Browse files Browse the repository at this point in the history
  • Loading branch information
byCedric committed Feb 21, 2024
1 parent f496d87 commit 91cb93a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions runtime/src/aliases/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const aliases: { [key: string]: any } = {
'react-native/Libraries/Utilities/PolyfillFunctions': require('react-native/Libraries/Utilities/PolyfillFunctions'), // Used by @sentry/react-native@3.4.2
'react-native/Libraries/Utilities/codegenNativeCommands': require('react-native/Libraries/Utilities/codegenNativeCommands'), // Used by react-native-webview@11.23.0
'react-native/Libraries/NativeComponent/NativeComponentRegistry': require('react-native/Libraries/NativeComponent/NativeComponentRegistry'), // Used by @shopify/react-native-skia@0.1.221
'react-native/Libraries/Utilities/codegenNativeComponent': require('react-native/Libraries/Utilities/codegenNativeComponent'), // Used by react-native-svg

// Does not work in Snackager, likely due to Webpack / Codegen
'react-native-pager-view': require('react-native-pager-view'),
Expand Down
1 change: 1 addition & 0 deletions snackager/src/bundler/externals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const CORE_EXTERNALS = [
'react-native-web/dist/modules/UnimplementedView', // Used by react-native-maps
'react-native/Libraries/Utilities/codegenNativeCommands', // Used by react-native-webview@11.23.0
'react-native/Libraries/NativeComponent/NativeComponentRegistry', // Used by `@shopify/react-native-skia@0.1.238`
'react-native/Libraries/Utilities/codegenNativeComponent', // Used by react-native-svg
'metro', // Used by expo-router
// TODO: decide whether to treat prop-types as an external or not
// previously it was always installed as a dependency and not treated as an external.
Expand Down

0 comments on commit 91cb93a

Please sign in to comment.