refactor: use fs.rm instead of fs.rmdir

expo · Jul 11, 2024 · f0bc530 · f0bc530
1 parent e8e27f1
commit f0bc530
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/runtime-shell/web/deploy-script.js b/runtime-shell/web/deploy-script.js
@@ -94,9 +94,13 @@ async function patchAssetPath(options) {
   }
 
   // Clean up folders without force-deleting it, if anything is left, it should fail on this part.
-  await fs.rmdir(path.resolve(exportPath, 'v2', String(semver.major(expoVersion)), 'assets'));
-  await fs.rmdir(path.resolve(exportPath, 'v2', String(semver.major(expoVersion))));
-  await fs.rmdir(path.resolve(exportPath, 'v2'));
+  await fs.rm(path.resolve(exportPath, 'v2', String(semver.major(expoVersion)), 'assets'), {
+    recursive: true,
+  });
+  await fs.rm(path.resolve(exportPath, 'v2', String(semver.major(expoVersion))), {
+    recursive: true,
+  });
+  await fs.rm(path.resolve(exportPath, 'v2'), { recursive: true });
 
   console.log(`✅ Moved ${filesOrFolders.length} public assets`);
 }

diff --git a/snackager/src/__e2e__/app.test.ts b/snackager/src/__e2e__/app.test.ts
@@ -32,7 +32,7 @@ describe('/serve', () => {
 
   afterEach(() => {
     process.env.DEBUG_LOCAL_FILES = originalEnv;
-    fs.rmdirSync(directory, { recursive: true });
+    fs.rmSync(directory, { recursive: true });
   });
 
   it('doesnt serve local files by default', async () => {