Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snackpub] cleanup cloud run deployment resources #449

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

Kudo
Copy link
Collaborator

@Kudo Kudo commented Jul 27, 2023

Why

since we migrated all snackpub traffic to k8s, we can then cleanup the resources for cloudrun

How

remove cloudrun deployment resources

Test Plan

review and let's see if that works after staging deployment

@Kudo Kudo marked this pull request as ready for review July 27, 2023 12:13
@Kudo Kudo requested a review from byCedric as a code owner July 27, 2023 12:13
@Kudo Kudo requested a review from randomhajile July 27, 2023 12:13
@Kudo Kudo merged commit a623aa8 into main Jul 28, 2023
4 checks passed
@Kudo Kudo deleted the @kudo/snackpub/remove-cloudrun branch July 28, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants