Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] fix device dialog store buttons and segmented buttons appearance #454

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Aug 15, 2023

Why

Fixes ENG-9448

How

Add small style tweaks to ensure that components are correctly displayed, no matter of selected theme.

Test Plan

The changes have been reviewed by running Snack stack locally.

Preview

@Simek Simek requested a review from byCedric as a code owner August 15, 2023 08:59
@linear
Copy link

linear bot commented Aug 15, 2023

ENG-9448 Color seems to be not correct in Snack's "Run your device" modal

CleanShot 2023-07-25 at 17.41.392x.png

  • Text color on top buttons when active
  • Background color of buttons at the bottom of the modal to download Expo Go app

@Simek Simek merged commit ff6d1dd into main Aug 16, 2023
5 checks passed
@Simek Simek deleted the @simek/website-fix-device-dialog branch August 16, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants