chore(ci): Google Cloud Workload Identity Federation #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicknovitski
force-pushed
the
wlif
branch
2 times, most recently
from
2c1ccb2
to
8540387
Compare
nicknovitski
had a problem deploying
to
snackager-staging
GitHub Actions
Failure
nicknovitski
had a problem deploying
to
snackager-staging
GitHub Actions
Failure
nicknovitski
had a problem deploying
to
snackager-staging
GitHub Actions
Failure
nicknovitski
temporarily deployed
to
snackager-staging
GitHub Actions
Inactive
ide
requested changes
Mar 22, 2024
ide
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I hope this will let us remove the service account key from our GitHub Actions secrets.
Test Plan
I was able to succesfully deploy snackager to staging, which suggests the other deployments will work too. https://github.com/expo/snack/actions/runs/8271897475/job/22632693926?pr=570