Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(snackager): add support for mjs and cjs file extensions #590

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jul 11, 2024

Why

Supersedes / closes #593

React navigation 7 will be published with both CJS and ESM builds. In order to support that, Snackager needs to be able to differentiate both.

How

  • Added test case for @react-navigation/native@7.x.x

Test Plan

See added tests + staging

@byCedric byCedric force-pushed the @bycedric/snackager/add-support-for-mjs-cjs-files branch 4 times, most recently from e3df98b to 46a84f1 Compare July 11, 2024 13:53
@byCedric byCedric force-pushed the @bycedric/snackager/add-support-for-mjs-cjs-files branch from 9d39ae8 to d152a8c Compare July 11, 2024 14:11
@byCedric byCedric marked this pull request as ready for review July 11, 2024 14:11
@byCedric byCedric merged commit 3563db1 into main Jul 11, 2024
8 checks passed
@byCedric byCedric deleted the @bycedric/snackager/add-support-for-mjs-cjs-files branch July 11, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant