Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(snackager): drop npm@6 version requirement #592

Merged
merged 7 commits into from
Jul 11, 2024

Conversation

byCedric
Copy link
Member

Why

Previously, we used npm bin to find the yarn binary. Unfortunately, npm@7+ dropped this command, causing us to pin the npm version to npm@6. This drops that version pinning requirement.

How

  • Swapped npm bin with which yarnpkg
  • Dropped npm version pinning

Test Plan

See CI & staging

@byCedric byCedric force-pushed the @bycedric/snackager/use-which-instead-of-npm branch from 51cef25 to a1049b0 Compare July 11, 2024 13:32
@byCedric byCedric merged commit 4c95790 into main Jul 11, 2024
25 checks passed
@byCedric byCedric deleted the @bycedric/snackager/use-which-instead-of-npm branch July 11, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant