-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade to Expo SDK 52 #614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
temporarily deployed
to
website-staging
October 29, 2024 14:34
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
snackager-staging
October 29, 2024 14:36
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
runtime-staging
October 29, 2024 14:41
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
runtime-staging
October 30, 2024 14:29
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
runtime-staging
October 30, 2024 14:40
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
runtime-staging
October 30, 2024 14:49
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
runtime-staging
October 30, 2024 17:01
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-main-ios-52.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-main-android-52.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-main-ios-51.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-main-android-51.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-main-ios-50.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-main-android-50.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-main-ios-49.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-main-ios-48.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-main-android-49.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-embed-ios-52.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-main-android-48.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-embed-ios-51.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-embed-android-52.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-embed-ios-50.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-embed-android-51.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-embed-ios-49.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-embed-android-50.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-embed-ios-48.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-embed-android-49.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
appetize-embed-android-48.0.0
October 30, 2024 17:06
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
runtime-staging
October 30, 2024 17:09
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
runtime-staging
October 30, 2024 17:29
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
runtime-staging
October 30, 2024 19:33
— with
GitHub Actions
Inactive
byCedric
deployed
to
appetize-main-android-50.0.0
November 11, 2024 11:12
— with
GitHub Actions
Active
byCedric
deployed
to
appetize-main-android-49.0.0
November 11, 2024 11:12
— with
GitHub Actions
Active
byCedric
deployed
to
appetize-main-android-48.0.0
November 11, 2024 11:12
— with
GitHub Actions
Active
byCedric
deployed
to
appetize-embed-android-52.0.0
November 11, 2024 11:12
— with
GitHub Actions
Active
byCedric
deployed
to
appetize-embed-android-51.0.0
November 11, 2024 11:12
— with
GitHub Actions
Active
byCedric
deployed
to
appetize-embed-android-50.0.0
November 11, 2024 11:12
— with
GitHub Actions
Active
byCedric
deployed
to
appetize-embed-android-49.0.0
November 11, 2024 11:12
— with
GitHub Actions
Active
byCedric
deployed
to
appetize-embed-android-48.0.0
November 11, 2024 11:12
— with
GitHub Actions
Active
byCedric
temporarily deployed
to
snackager-staging
November 11, 2024 11:33
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
website-staging
November 11, 2024 11:33
— with
GitHub Actions
Inactive
byCedric
temporarily deployed
to
runtime-staging
November 11, 2024 11:35
— with
GitHub Actions
Inactive
byCedric
commented
Nov 11, 2024
@@ -7,6 +7,7 @@ const assets = { | |||
}; | |||
|
|||
const sdks: { [version: string]: SDKSpec } = { | |||
// TODO(cedric): drop SDK 48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, not going to drop 48 in this PR. This will be a follow-up, likely next week to also bump SDK 52 to latest again.
byCedric
force-pushed
the
@bycedric/sdk-52
branch
from
November 11, 2024 13:34
7e3bea7
to
d752c0f
Compare
Going to merge this, and open a PR to upgrade the snack-runtime package separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This is a maintenance release, to upgrade to SDK 52. Note, this PR does not turn SDK 52 into the default SDK yet. We still need more testing for that.
Important
This PR should be merged after upgrading to the first stable SDK 52 version.How
See commits, followed the upgrade guide.
Test Plan
See staging.