Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade to Expo SDK 52 #614

Merged
merged 21 commits into from
Nov 11, 2024
Merged

refactor: upgrade to Expo SDK 52 #614

merged 21 commits into from
Nov 11, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Oct 29, 2024

Why

This is a maintenance release, to upgrade to SDK 52. Note, this PR does not turn SDK 52 into the default SDK yet. We still need more testing for that.

Important

This PR should be merged after upgrading to the first stable SDK 52 version.

How

See commits, followed the upgrade guide.

Test Plan

See staging.

@byCedric byCedric temporarily deployed to appetize-main-ios-52.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-main-android-52.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-main-ios-51.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-main-android-51.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-main-ios-50.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-main-android-50.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-main-ios-49.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-main-ios-48.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-main-android-49.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-embed-ios-52.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-main-android-48.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-embed-ios-51.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-embed-android-52.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-embed-ios-50.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-embed-android-51.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-embed-ios-49.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-embed-android-50.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-embed-ios-48.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-embed-android-49.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric temporarily deployed to appetize-embed-android-48.0.0 October 30, 2024 17:06 — with GitHub Actions Inactive
@byCedric byCedric deployed to appetize-main-ios-50.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-main-android-50.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-main-ios-49.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-main-ios-48.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-main-android-49.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-embed-ios-52.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-main-android-48.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-embed-ios-51.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-embed-android-52.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-embed-ios-50.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-embed-android-51.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-embed-ios-49.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-embed-android-50.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-embed-ios-48.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-embed-android-49.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@byCedric byCedric deployed to appetize-embed-android-48.0.0 November 11, 2024 11:12 — with GitHub Actions Active
@@ -7,6 +7,7 @@ const assets = {
};

const sdks: { [version: string]: SDKSpec } = {
// TODO(cedric): drop SDK 48
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, not going to drop 48 in this PR. This will be a follow-up, likely next week to also bump SDK 52 to latest again.

@byCedric
Copy link
Member Author

Going to merge this, and open a PR to upgrade the snack-runtime package separately.

@byCedric byCedric merged commit 29ca412 into main Nov 11, 2024
23 of 24 checks passed
@byCedric byCedric deleted the @bycedric/sdk-52 branch November 11, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant