deps: upgrade eslint #6118
Open
deps: upgrade eslint #6118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
reviewed
Nov 1, 2024
Comment on lines
+1
to
+27
| export default [ | ||
| { | ||
| // Define language options | ||
| languageOptions: { | ||
| sourceType: 'module', // or 'commonjs' based on your project | ||
| globals: { | ||
| // Add any global variables you need | ||
| __dirname: true, | ||
| process: true, | ||
| }, | ||
| }, | ||
| rules: { | ||
| 'eol-last': 'error', | ||
| 'eqeqeq': ['error', 'allow-null'], | ||
| 'indent': ['error', 2, { MemberExpression: 'off', SwitchCase: 1 }], | ||
| 'no-trailing-spaces': 'error', | ||
| 'no-unused-vars': [ | ||
| 'error', | ||
| { | ||
| vars: 'all', | ||
| args: 'none', | ||
| ignoreRestSiblings: true, | ||
| } | ||
| ], | ||
| }, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
I think that the config will require a team agreement.
There was a problem hiding this comment.
After i upgrade eslint, it need additional file config, and no need eslintrc yml, eslintignore. eslint config is the result converted from eslintrc, and i dont add rules or changes rule.
bjohansebas
reviewed
Dec 2, 2024
| @@ -492,7 +492,7 @@ describe('res', function(){ | |||
| function tryRequire (name) { | |||
| try { | |||
| return require(name) | |||
| } catch (e) { | |||
There was a problem hiding this comment.
Why use finally here and catch in the others?
|
We have had 2 or 3 conversations about how we want to approach linting going forward. AFAICT doing an in place upgrade with a config like this is not on the table. We are considering two things:
I think we should close this personally and pursue one of those options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6103 (comment)