fix: search example to support Redis v4+ and Express 4/5 #6274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Search example to address issues caused by breaking changes in Redis v4+ and Express 5.
Key changes include:
sadd
withsAdd
andsmembers
withsMembers
for Redis v4+ compatibility.{0,1}
syntax for optional parameters instead of?
to support Express 5.These changes ensure the example works seamlessly.
Tested locally with:
Redis 7.0.15
Node.js 22.12.0
Express 5.0.1 and 4.21.2
Debian 12
Note:
Adding automated tests for this example could help catch issues like this sooner. If you think it's worthwhile, I’d be glad to help implement them.