Define the "open" flag for the dev command

extension-js · Oct 20, 2024 · 1267aeb · 1267aeb
1 parent 67fd70c
commit 1267aeb
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/programs/cli/cli.ts b/programs/cli/cli.ts
@@ -118,14 +118,20 @@ extensionJs
     '-p, --port <number>',
     'what port should Extension.js WebSocket server run. Defaults to `8000`'
   )
+  .option(
+    '-o, --open [boolean]',
+    'whether or not to open the browser automatically. Defaults to `true`'
+  )
   .action(async function (
     pathOrRemoteUrl: string,
     {browser = 'chrome', ...devOptions}: DevOptions
   ) {
     for (const vendor of vendors(browser)) {
       await extensionDev(pathOrRemoteUrl, {
         browser: vendor as DevOptions['browser'],
-        ...devOptions
+        ...devOptions,
+        // @ts-expect-error open is a boolean
+        open: devOptions.open === 'false' ? false : true
       })
     }
   })

diff --git a/programs/develop/commands/commands-lib/config-types.ts b/programs/develop/commands/commands-lib/config-types.ts
@@ -5,7 +5,7 @@ import {BuildOptions} from '../build'
 
 type BrowserConfig = Pick<
   DevOptions,
-  | 'noOpen'
+  | 'open'
   | 'profile'
   | 'preferences'
   | 'browserFlags'

diff --git a/programs/develop/commands/dev.ts b/programs/develop/commands/dev.ts
@@ -18,7 +18,7 @@ export interface DevOptions {
   browser: 'chrome' | 'edge' | 'firefox' | 'chromium-based' | 'gecko-based'
   mode: 'development' | 'production' | 'none' | undefined
   port?: number
-  noOpen?: boolean
+  open?: boolean
   userDataDir?: string
   profile?: string
   preferences?: Record<string, any>

diff --git a/programs/develop/commands/start.ts b/programs/develop/commands/start.ts
@@ -17,7 +17,7 @@ export interface StartOptions {
   mode: 'development' | 'production'
   browser: DevOptions['browser']
   port?: number
-  noOpen?: boolean
+  open?: boolean
   userDataDir?: string
   polyfill?: boolean
   chromiumBinary?: string

diff --git a/programs/develop/webpack/webpack-config.ts b/programs/develop/webpack/webpack-config.ts
@@ -127,7 +127,8 @@ export default function webpackConfig(
         stats: true,
         port: devOptions.port || 8000
       }),
-      !devOptions.noOpen &&
+      // Open defaults to true
+      devOptions.open !== false &&
         new BrowsersPlugin({
           extension: [
             userExtensionOutputPath,