Rebase

extension-js · Aug 13, 2024 · 2520b01 · 2520b01
1 parent 7457fc0
commit 2520b01
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 7 deletions.
diff --git a/programs/develop/commands/build.ts b/programs/develop/commands/build.ts
@@ -17,7 +17,6 @@ import {loadExtensionConfig} from './commands-lib/get-extension-config'
 import {DevOptions} from './dev'
 
 export interface BuildOptions {
-  mode: 'development' | 'production'
   browser?: DevOptions['browser']
   zipFilename?: string
   zip?: boolean
@@ -40,7 +39,7 @@ export async function extensionBuild(
   }
 
   try {
-    const browser = buildOptions.browser || 'chrome'
+    const browser = buildOptions?.browser || 'chrome'
     const baseConfig = webpackConfig(projectPath, {
       ...buildOptions,
       browser,
@@ -62,11 +61,12 @@ export async function extensionBuild(
     const compilerConfig = merge(userConfig)
     const compiler = webpack(compilerConfig)
 
-    compiler.run(async (err, stats) => {
-      if (err) {
-        console.error(err.stack || err)
-        process.exit(1)
-      }
+    return new Promise((resolve, reject) => {
+      compiler.run(async (err, stats) => {
+        if (err) {
+          console.error(err.stack || err)
+          return reject(err)
+        }
 
         console.log(messages.buildWebpack(projectPath, stats, browser))
 

diff --git a/yarn.lock b/yarn.lock
@@ -2119,6 +2119,24 @@
     schema-utils "^4.2.0"
     source-map "^0.7.3"
 
+"@prefresh/core@^1.5.0":
+  version "1.5.2"
+  resolved "https://registry.yarnpkg.com/@prefresh/core/-/core-1.5.2.tgz#750e1936d82f3b0a1199d3cda5c35e3443128490"
+  integrity sha512-A/08vkaM1FogrCII5PZKCrygxSsc11obExBScm3JF1CryK2uDS3ZXeni7FeKCx1nYdUkj4UcJxzPzc1WliMzZA==
+
+"@prefresh/utils@^1.2.0":
+  version "1.2.0"
+  resolved "https://registry.yarnpkg.com/@prefresh/utils/-/utils-1.2.0.tgz#cbdfe549b207041e38bb6cc382408b30cd24fec8"
+  integrity sha512-KtC/fZw+oqtwOLUFM9UtiitB0JsVX0zLKNyRTA332sqREqSALIIQQxdUCS1P3xR/jT1e2e8/5rwH6gdcMLEmsQ==
+
+"@prefresh/webpack@^4.0.1":
+  version "4.0.1"
+  resolved "https://registry.yarnpkg.com/@prefresh/webpack/-/webpack-4.0.1.tgz#f2572707e70c6c30a5cafbcfc5c9915ff8f0d37c"
+  integrity sha512-BAzEqkNZSm1B82l8oXp+b69ffCQopjca8yeooczmCBSU6ZGhxWf+G2fmRt02CkcMpnDiHuDNDdsBJqEBKRJzOQ==
+  dependencies:
+    "@prefresh/core" "^1.5.0"
+    "@prefresh/utils" "^1.2.0"
+
 "@rollup/rollup-android-arm-eabi@4.20.0":
   version "4.20.0"
   resolved "https://registry.yarnpkg.com/@rollup/rollup-android-arm-eabi/-/rollup-android-arm-eabi-4.20.0.tgz#c3f5660f67030c493a981ac1d34ee9dfe1d8ec0f"