From cd47ddcefab965f36313b72b9774f1303d972e31 Mon Sep 17 00:00:00 2001 From: Cezar Augusto Date: Thu, 22 Aug 2024 16:37:50 -0300 Subject: [PATCH] Better output message for multi-browser runs --- .../plugin-browsers/browsers-lib/messages.ts | 4 ++-- .../plugin-browsers/run-chromium/index.ts | 11 ++++++++--- .../develop/plugin-browsers/run-firefox/index.ts | 16 +++++++++------- .../manager-extension-firefox/background.js | 2 +- .../web-socket-server/start-server.ts | 6 ++---- 5 files changed, 22 insertions(+), 17 deletions(-) diff --git a/programs/develop/plugin-browsers/browsers-lib/messages.ts b/programs/develop/plugin-browsers/browsers-lib/messages.ts index 04c7e723..21d9d2f9 100644 --- a/programs/develop/plugin-browsers/browsers-lib/messages.ts +++ b/programs/develop/plugin-browsers/browsers-lib/messages.ts @@ -65,8 +65,8 @@ export function browserNotInstalled( export function creatingUserProfile(browser: DevOptions['browser']) { const browsername = capitalizedBrowserName(browser) return ( - `${getLoggingPrefix(browser, 'info')} Creating ${browsername} ` + - `user profile directory...` + `${getLoggingPrefix(browser, 'info')} Creating new ${browsername} ` + + `user profile...` ) } diff --git a/programs/develop/plugin-browsers/run-chromium/index.ts b/programs/develop/plugin-browsers/run-chromium/index.ts index 28aa0f9a..7e70160e 100644 --- a/programs/develop/plugin-browsers/run-chromium/index.ts +++ b/programs/develop/plugin-browsers/run-chromium/index.ts @@ -89,9 +89,14 @@ export class RunChromiumPlugin { this.launchChromium(this.browser) - console.log( - messages.stdoutData(this.browser, compilation.compilation.options.mode) - ) + setTimeout(() => { + console.log( + messages.stdoutData( + this.browser, + compilation.compilation.options.mode + ) + ) + }, 2000) chromiumDidLaunch = true done() diff --git a/programs/develop/plugin-browsers/run-firefox/index.ts b/programs/develop/plugin-browsers/run-firefox/index.ts index f2a8ef43..e14d7f23 100644 --- a/programs/develop/plugin-browsers/run-firefox/index.ts +++ b/programs/develop/plugin-browsers/run-firefox/index.ts @@ -98,15 +98,17 @@ export class RunFirefoxPlugin { return } + setTimeout(() => { + console.log( + messages.stdoutData( + this.browser, + compilation.compilation.options.mode + ) + ) + }, 2000) + await this.launchFirefox(compiler) - console.log( - messages.stdoutData( - // extensionManifest.name, - this.browser, - compilation.compilation.options.mode - ) - ) firefoxDidLaunch = true done() } diff --git a/programs/develop/webpack/plugin-reload/extensions/manager-extension-firefox/background.js b/programs/develop/webpack/plugin-reload/extensions/manager-extension-firefox/background.js index a7d217a5..74ce743e 100644 --- a/programs/develop/webpack/plugin-reload/extensions/manager-extension-firefox/background.js +++ b/programs/develop/webpack/plugin-reload/extensions/manager-extension-firefox/background.js @@ -1,4 +1,4 @@ -import {createFirefoxAddonsTab, handleFirstRun} from './define-initial-tab.js' +import {handleFirstRun} from './define-initial-tab.js' import {connect, disconnect} from './reload-service.js' function bgGreen(str) { diff --git a/programs/develop/webpack/plugin-reload/steps/create-web-socket-server/web-socket-server/start-server.ts b/programs/develop/webpack/plugin-reload/steps/create-web-socket-server/web-socket-server/start-server.ts index 3f89f5a3..8b3d37c2 100644 --- a/programs/develop/webpack/plugin-reload/steps/create-web-socket-server/web-socket-server/start-server.ts +++ b/programs/develop/webpack/plugin-reload/steps/create-web-socket-server/web-socket-server/start-server.ts @@ -72,10 +72,8 @@ export async function startServer(compiler: Compiler, options: DevOptions) { path.join(projectPath, 'manifest.json') ) - setTimeout(() => { - console.log(messages.runningInDevelopment(manifest, message)) - console.log('') - }, 2500) + console.log(messages.runningInDevelopment(manifest, message)) + console.log('') if (isFirstRun(options.browser)) { setTimeout(() => {