-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add several tests to templates #109
Conversation
- Remove old checks of past extension-create namespace - Extension.js ASCII art ;)
- Removed minimal Node version to run
- Add tests - Rename side_panel with siidebar (parity) - Replace images/ with public/ (parity)
6a73f8e
to
aa640a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The statement that imports semver
can be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code refactoring is very good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed these unit tests and found no issues other than they run slowly.
Do you have any thoughts on ensuring the extension operates correctly in a browser environment? Should we consider incorporating end-to-end testing for this purpose?
@OSpoon thanks for reviewing! Regarding the e2e tests: yes, that would be ideal. This PR adds tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
Added a bunch of tests to cover CLI commands against the base templates.
Files changed ended up too big but mostly due to the fixtures I had to add to test the build command.
I also made a few changes to templates and tried to come up with a pattern for new additions. This is a starter to allow authors to add their own templates to our list.
Feedback welcome!