Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chrome.windows.create API not working #117

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix chrome.windows.create API not working #117

merged 1 commit into from
Jun 28, 2024

Conversation

cezaraugusto
Copy link
Member

The resolver plugin didn't catch this case which raised a bug

Address #112

@cezaraugusto cezaraugusto requested a review from OSpoon June 28, 2024 13:39
@cezaraugusto cezaraugusto self-assigned this Jun 28, 2024
@cezaraugusto cezaraugusto mentioned this pull request Jun 28, 2024
Closed
OSpoon
OSpoon approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@OSpoon OSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@cezaraugusto cezaraugusto merged commit b0391db into main Jun 28, 2024
6 checks passed
@cezaraugusto cezaraugusto deleted the window-api-bug branch June 28, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OSpoon OSpoon OSpoon approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cezaraugusto @OSpoon