Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several performance improvements #137

Merged
merged 92 commits into from
Aug 9, 2024
Merged

Several performance improvements #137

merged 92 commits into from
Aug 9, 2024

Conversation

cezaraugusto
Copy link
Member

@cezaraugusto cezaraugusto commented Jul 24, 2024

This is a big bundle of changes to make Extension.js lighter and more performant.

Also:

Simplified interface:

Screenshot 2024-08-06 at 15 13 20

Single utility dev tools for Extension.js browser support

Screenshot 2024-08-06 at 15 14 01

@OSpoon
Copy link
Member

OSpoon commented Aug 8, 2024

hi @cezaraugusto,
Please check if new-preact, content-preact, new-less, and new-sass are working correctly.

@cezaraugusto
Copy link
Member Author

@OSpoon new-less and and new-sass are reloading well, but it seems there is something with the resolver plugin that is preventing the scripting API from injecting styles into the page using these templates.

for new-preact, content-preact, they build properly but still can't reload the page

@cezaraugusto
Copy link
Member Author

I'm investigating why the resolver isn't working properly

@cezaraugusto
Copy link
Member Author

@OSpoon anything else you want to include in this PR before we merge? I'm OK having a Preact fix in a future release.

@cezaraugusto cezaraugusto self-assigned this Aug 8, 2024
@OSpoon
Copy link
Member

OSpoon commented Aug 9, 2024

I spent some time looking into why new-preact is not reloading the page, but unfortunately, I haven't found the cause yet. The preact-webpack repo I created seems to be working fine.

I haven't been involved much in browser extensions and build-related work, so I don't have any good ideas at the moment. If I come up with anything new, I'll let you know right away. 😁

@cezaraugusto cezaraugusto marked this pull request as ready for review August 9, 2024 13:52
@cezaraugusto
Copy link
Member Author

@OSpoon awesome, let's get this one into main

@cezaraugusto cezaraugusto merged commit 49f0da3 into main Aug 9, 2024
6 checks passed
@cezaraugusto cezaraugusto deleted the extension/develop branch August 9, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants