-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate types generation to extension package #162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
cezaraugusto
force-pushed
the
pnpm-support
branch
4 times, most recently
from
September 1, 2024 14:36
3d94d37
to
c2c4fa5
Compare
cezaraugusto
force-pushed
the
pnpm-support
branch
from
September 1, 2024 15:16
c2c4fa5
to
089f3aa
Compare
cezaraugusto
force-pushed
the
pnpm-support
branch
2 times, most recently
from
September 1, 2024 23:16
1371507
to
1bfdfc7
Compare
OSpoon
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working well.
cezaraugusto
force-pushed
the
pnpm-support
branch
from
September 2, 2024 11:19
1bfdfc7
to
bd81814
Compare
commit: |
@karlhorky thanks for the follow-up! Hopefully fixed in #165 |
cezaraugusto
added a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to pnpm. Fix #147.
How to test
Run the
create
command via pnpx, then the `dev1 command.cc @karlhorky this is in v2.0.0-alpha.8 already. Feel free to test/review and let me know if this doesn't work somehow.