Fix content_scripts not working in production #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
commit: |
cezaraugusto
force-pushed
the
css-prod
branch
from
c970b9a
to
97829b2
Compare
cezaraugusto
force-pushed
the
css-prod
branch
from
97829b2
to
5b0aee8
Compare
|
@OSpoon I'm going to merge this one for the next hotfix release but please report if I'm wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #166
This bug often pops up but hopefully this is a permanent fix. In webpack we use style-loader for dev and mini-css-extract-plugin for prod. In prod the content_script styles are emitted but we never reference them in the manifest. This PR fixes it.
Test plan is mostly running "build" in your favorite
content_*andnew_*templates and assert CSS works both in dev and prod.