-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix web_resources match patterns #178
Fix web_resources match patterns #178
Conversation
@@ -64,7 +65,7 @@ export class WebResourcesPlugin { | |||
resources: resources.filter( | |||
(resource) => !resource.endsWith('.map') | |||
), | |||
matches | |||
matches: cleanMatches(matches), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you write a comment on top of this with the reasoning of why this is needed? this is for future reference.
if you're feeling adventurous, would love to have the first test for the feature-web-resources plugin. It's mainly creating a __spec__/clean-matches.spec.ts
file with some edge cases. I'm using tests/comments as a reference to populate the new docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment and some tests 👍
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch and tests! Looking great
Available in v2.0.0-alpha.28 |
Fixes #177