Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to run any Chromium-based or Gecko-based browsers #186

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

cezaraugusto
Copy link
Member

Fix #59

Support is via --chromium-binary and --gecko-binary flags.

You can run Brave, for example:

Screenshot 2024-09-16 at 01 22 51

Test Plan

# Assuming you're on macOS
pnpm extension dev ./examples/new-env --chromium-binary="/Applications/Brave Browser.app/Contents/MacOS/Brave Browser"

@cezaraugusto cezaraugusto self-assigned this Sep 16, 2024
Copy link

pkg-pr-new bot commented Sep 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/extension-js/extension.js/extension-create@186
pnpm add https://pkg.pr.new/extension-js/extension.js/extension@186
pnpm add https://pkg.pr.new/extension-js/extension.js/extension-develop@186

commit: 8304aae

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Member

@OSpoon OSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two new flags are great, they run well~

@cezaraugusto cezaraugusto merged commit cbf2c9b into main Sep 16, 2024
26 checks passed
@cezaraugusto cezaraugusto deleted the browser-updates branch September 16, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to develop on any Chromium-based Browser
2 participants