Massive updates to properly add support to the public/ folder #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
cezaraugusto
force-pushed
the
public
branch
from
ec78d8b
to
1e3f7e8
Compare
We parse the manifest to remove the browser-specific fields, and at some point we will require a configuration that is browser-specific and we are not aware, raising a bug. This patch removes all manifest requires possible, and patch with the browser-specific fields method to remove them as needed
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
cezaraugusto
force-pushed
the
public
branch
from
283deca
to
b0292d2
Compare
Possibly address #149
cezaraugusto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public/ folder was wrongly implemented since the very first version. This PR changes it.
The goal of the public/ folder in Extension.js is to provide a predictable output path of static assets to users. If I add a
/public/myimage.pngfile, it is expected that the file is served at/myimage.png, so a call tochrome.runtime.getURL('myimage.png')should correctly point to my image.Before this change, the public path is served at
/public/.The landing of this change puts us in
betarelease.