Feature/579 #965
Open
Feature/579 #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mellelieuwes
requested changes
Sep 28, 2024
| { | ||
| :noreply, | ||
| socket |> assign(page_ref: page_ref) |
There was a problem hiding this comment.
Consider to add an extra check on wysiwyg field text. If no text, there is no real reason for the confirmation.
| @impl true | ||
| def compose(:confirmation_modal, %{entity: %{consent_agreement: consent_agreement}}) do | ||
| %{ | ||
| module: Pixel.ConfirmationModal, |
There was a problem hiding this comment.
“By skipping the consent, not only will the text be deleted, but the underlying consent agreement and all associated signatures will also be removed. It would be beneficial to clarify this in the body of the confirmation modal, as the current text is static.
Additionally, you may want to implement a check on the consent agreement. If no signatures are present, there is no need to include this clarification in the confirmation modal, as the default text will suffice in such cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.