Merge pull request #34 from trbKnl/fix-terminate-vis-engine

added code to terminate() so it calls unmount on ReactDom.Root
eyra · Apr 1, 2023 · 7189f59 · 7189f59
2 parents aef72ec + 6e9cca4
commit 7189f59
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/framework/visualisation/react/engine.tsx b/src/framework/visualisation/react/engine.tsx
@@ -40,7 +40,10 @@ export default class ReactEngine implements VisualisationEngine {
     })
   }
 
-  terminate (): void {}
+  terminate (): void {
+    console.log('[ReactEngine] stopped')
+    this.root.unmount()
+  }
 
   renderElements (elements: JSX.Element[]): void {
     this.root.render(<Main elements={elements} />)