Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31296: As an Editor I want be able to edit custom attributes and styles for links #1198

Open
wants to merge 1 commit into
base: 1.5
Choose a base branch
from

Conversation

SerheyDolgushev
Copy link
Contributor

Question Answer
Tickets EZP-31296
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

There is no UI to edit custom attributes and styles for link elements. Even if you will specify the following configurations:

system:
    default:
        fieldtypes:
            ezrichtext:
                classes:
                    link:
                        choices: [custom-link-1, custom-link-2, custom-link-3]
                        default_value: custom-link-1
                        required: false
                        multiple: false

This PR provides a way to edit custom attributes and classes only for existing links. Please note, it still is impossible to set them when a new link is created. Also, some minor UI fixes might be required here. But it is better to have this option than no option at all.

link_edit_custom_attributes

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@dew326
Copy link
Member

dew326 commented Jan 16, 2020

Thanks for your contribution.
The code itself looks ok. We need to check with our PMs if we want this feature it that way (I remember we have plans for this), so I summon @SylvainGuittard

@SylvainGuittard
Copy link
Contributor

Thanks @SerheyDolgushev for the contribution.
@dew326 The feature is totally valid. I checked with @inakijv. He worked on some wireframes. He should be able to share them soon.

@SerheyDolgushev
Copy link
Contributor Author

@SylvainGuittard sorry, any update on this?

@SylvainGuittard
Copy link
Contributor

@SerheyDolgushev Thanks for the reminder, I will come back to you soon.

@ChrisMoutsos
Copy link

Sorry, is there any update on this one?

@ChrisMoutsos
Copy link

Sorry, forgot to ping @SylvainGuittard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants