Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6592: Removed unusable location/subtree limitations from state/assign policy #398

Merged
merged 1 commit into from
Apr 24, 2024
Merged

IBX-6592: Removed unusable location/subtree limitations from state/assign policy #398

merged 1 commit into from
Apr 24, 2024

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Dec 20, 2023

Question Answer
JIRA issue IBX-6592
Type bug
Target Ibexa version v3.3
BC breaks ?

As agreed in ezsystems/ezplatform-admin-ui#2112 (comment) we decided to remove Subtree and Node limitations from state/assign policy.

Cleanup SQL PR: https://github.com/ibexa/installer/pull/134

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4 barw4 added Bug Something isn't working Ready for review labels Dec 20, 2023
@barw4 barw4 self-assigned this Dec 20, 2023
@barw4 barw4 requested a review from a team December 20, 2023 16:16
@barw4 barw4 marked this pull request as ready for review December 20, 2023 16:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza requested a review from a team February 23, 2024 08:33
alongosz
alongosz reviewed Feb 27, 2024
View reviewed changes
phpstan-baseline.neon Outdated Show resolved Hide resolved
@Steveb-p Steveb-p force-pushed the ibx-6592-remove-location-limitations-object-state branch from b4eefc7 to ca3d530 Compare February 28, 2024 12:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tomaszszopinski tomaszszopinski self-assigned this Apr 22, 2024
tomaszszopinski
tomaszszopinski approved these changes Apr 24, 2024
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 commerce.

@Steveb-p Steveb-p merged commit 245d02e into 1.3 Apr 24, 2024
23 checks passed
@Steveb-p Steveb-p deleted the ibx-6592-remove-location-limitations-object-state branch April 24, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@kisztof kisztof kisztof approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

@barw4 barw4

@tomaszszopinski tomaszszopinski

Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@barw4 @kisztof @mikadamczyk @Steveb-p @alongosz @ViniTou @konradoboza @tomaszszopinski @webhdx