-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8562: Fixed flooding content attributes table with duplicates #409
Conversation
Given how the issue comes up when multiple layers interact with each other, this almost requires tests - either adjustment of already present ones, or new ones. I'd accept this only with an explanation why this works, ideally with a promise of tests being added at least to 4.6 to show the issue in the new testing framework. |
The JIRA ticket mentions a SQL script to remove the duplicated entries - if we decide to create one please let us (the Knowledge Team) know, we will have to document it in the update doc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current status of retests.
https://issues.ibexa.co/browse/IBX-8562
OK
https://issues.ibexa.co/browse/IBX-8492
Content view works but editing item causes error:
(under verification by @Nattfarinn)
3d1f30c
to
36b051b
Compare
eZ/Publish/Core/Persistence/Legacy/Tests/Content/ContentHandlerTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Tests/Content/ContentHandlerTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Tests/Content/FieldHandlerTest.php
Outdated
Show resolved
Hide resolved
Retest status: on v3.3 404 persists when editing item with only field replaced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still missing some coverage on integration level, with database.
You should be able to query database via tests by getting \Doctrine\DBAL\Connection
service from the test container (it's already exposed).
// for 4.6
eZ/Publish/Core/Persistence/Legacy/Tests/Content/ContentHandlerTest.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK from my side now.
Hi 🙂 we now have ~10 million duplicates in our table and the database grew around 3GB in disk size. Since a few days, the production database is throwing error messages ( ...but sure... take your time discussing what kind of null check you want to do. Nothing to worry about! |
Hi @eWert-Online! First of all my apologies for the situation. I understand your frustration but I would like to ensure you that we are aware of importance of this patch and we are actively working on providing the solution. Unfortunately, Github does not give a full visibility of our intense activities behind the scenes. Currently proposed changes are going through Quality Assurance process. As soon as we will be ready we will do the 3.3.40 and 4.6.10 release. |
Quality Gate passedIssues Measures |
+ IBX-8492: Fixed replacing only field of Content Type with virtual field
v3.3
Checklist:
$ composer fix-cs
).@ezsystems/engineering-team
).