Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PHPStan #104

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Added PHPStan #104

merged 4 commits into from
Aug 16, 2023

Conversation

Steveb-p
Copy link
Contributor

Question Answer
JIRA issue N/A
Type improvement
Target version v3.3
BC breaks no
Tests pass yes
Doc needed no

This PR adds PHPStan default setup to 3.x.

⚠️ Ignore when merging up.

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@Steveb-p Steveb-p requested a review from a team August 14, 2023 11:54
konradoboza
konradoboza approved these changes Aug 16, 2023
View reviewed changes
.github/workflows/ci.yaml Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team August 16, 2023 06:19
Steveb-p and others added 2 commits August 16, 2023 09:42
@Steveb-p
Update .github/workflows/ci.yaml
d0412e9 
Co-authored-by: Konrad Oboza <konrad.oboza@ez.no>
@Steveb-p
Revert "Update .github/workflows/ci.yaml"
8f3331f 
This reverts commit d0412e9.
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou merged commit 8383147 into 1.3 Aug 16, 2023
13 checks passed
@ViniTou ViniTou deleted the phpstan-3 branch August 16, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Steveb-p @ViniTou @konradoboza @alongosz