Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compilation metrics parsing #13

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

jamesjwu
Copy link
Collaborator

@jamesjwu jamesjwu commented Apr 3, 2024

Adds an initial version of compilation metrics parsing. We can definitely do more here and make it prettier/more useful, but thought I'd start with something.

Example output:
image

TODOs:

  • Parse start time and make it into a date time
  • Show inductor outputs on same page if available
  • More tooltips for existing metrics
  • Link to a stack trace for any failure reason or restart reason. I think we should have the stack trace from the stack trie.

@@ -18,6 +18,7 @@ path = "src/cli.rs"
[dependencies]
anyhow = "1.0.75"
base16ct = "0.2.0"
chrono = "0.4"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this dep in preparation for better handling of DateTimes, might as well get it set up internally

@jamesjwu jamesjwu requested a review from ezyang April 3, 2024 19:45
@jamesjwu jamesjwu merged commit f091d1d into main Apr 4, 2024
12 checks passed
@ezyang
Copy link
Owner

ezyang commented Apr 4, 2024

Some quick notes:

  • We can also test on the PyTorch end that the generated logs are parseable via the test_structured_trace test. Here you would cut a tlparse release and then update the version number pin in PyTorch test suite
  • Something I really, really want is for the success/fail status to be shown on the stack trie, as right now all compilation attempts are shown but some could have graph break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants