Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for structured logs to render links in tlparse #36

Merged
merged 1 commit into from
May 16, 2024

Conversation

jamesjwu
Copy link
Collaborator

@jamesjwu jamesjwu commented May 16, 2024

Generalize parsers so that they can output either a file or a URL. URLs don't appear in the ParseOutput that parse_path returns, but they do appear in the compile directory.

image

@jamesjwu
Copy link
Collaborator Author

Also fixed the gitignore to not ignore logs in the test directory

@jamesjwu jamesjwu requested a review from ezyang May 16, 2024 19:08
@jamesjwu jamesjwu merged commit a8b4c08 into main May 16, 2024
13 checks passed
@jamesjwu
Copy link
Collaborator Author

Will work on #5 when I get a chance so the link doesn't just hang out so weirdly in the middle of the build products

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant