Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: 테스트커버리지 #5

Closed
junha-ahn opened this issue Jul 1, 2023 · 2 comments · Fixed by #20
Closed

CI: 테스트커버리지 #5

junha-ahn opened this issue Jul 1, 2023 · 2 comments · Fixed by #20
Assignees
@junha-ahn @hihahayoung
Labels
enhancement New feature or request major Major topic

Comments

@junha-ahn
Copy link
Member

junha-ahn commented Jul 1, 2023 •
edited
Loading

Description

테스트커버리지 측정을 위한 도구를 세팅해주세요

etc. 코드 퀄리티 진단 - codebeat/sonarqube - 키워드 조사

To do

  • git actions와 intellij 모두 지원해야합니다.
  • 각 환경 마다 각각의 설정이 존재하는게 아니라, 통합된 설정을 제공해주세요
  • (git actions) coverage check의 경우 모든 PR에 해당 actions이 동작해야 합니다

110061018-ab82d800-7d1b-11eb-9ecc-05ac4ef22e6d

Test Checklist
@junha-ahn junha-ahn added the enhancement New feature or request label Jul 1, 2023
@junha-ahn junha-ahn moved this to Todo in Kanban backend Jul 1, 2023
@hihahayoung hihahayoung moved this from Todo to In Progress in Kanban backend Jul 2, 2023
@junha-ahn
Copy link
Member Author

junha-ahn commented Jul 9, 2023 •
edited
Loading

reference Jacoco

다만 jacoco 는 html/xml/csv 형식으로 출력

  • 특정 minimum을 못 넘으면 error를 출력할 수 는 있지만, CLI에 직접 coverage report를 뿌리는 기능이 필요 (즉각즉각 피드백)
  • 적어도 git actions를 통해 pr에 report가 출력되어야함

@junha-ahn junha-ahn self-assigned this Jul 9, 2023
@junha-ahn junha-ahn mentioned this issue Jul 9, 2023
Merged
@junha-ahn
Copy link
Member Author

junha-ahn commented Jul 9, 2023 •
edited
Loading

closed by #20

최종

  • add Jacoco into Gradle
  • add Jacoco Report(xml file) into Codecov, so you can see CoverageReport directly In PR

@github-project-automation github-project-automation bot moved this from In Progress to Done in Kanban backend Jul 9, 2023
@junha-ahn junha-ahn linked a pull request Jul 17, 2023 that will close this issue
chore: add test coverage #20
Merged
@junha-ahn junha-ahn added the major Major topic label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junha-ahn junha-ahn

@hihahayoung hihahayoung

Labels
enhancement New feature or request major Major topic
Projects
Kanban backend
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add test coverage f-lab-clone/ticketing-backend
2 participants
@junha-ahn @hihahayoung