Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/113 remove total count #124

Merged
merged 1 commit into from
Oct 16, 2023
Merged

feat/113 remove total count #124

merged 1 commit into from
Oct 16, 2023

Conversation

minjun3021
Copy link
Collaborator

@minjun3021 minjun3021 commented Oct 16, 2023

What is this PR?

Key Changes

Test Checklist

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (25bd54f) 84.69% compared to head (8a83c29) 82.60%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #124      +/-   ##
============================================
- Coverage     84.69%   82.60%   -2.10%     
+ Complexity      152      147       -5     
============================================
  Files            42       42              
  Lines           732      730       -2     
  Branches         31       31              
============================================
- Hits            620      603      -17     
- Misses           91      104      +13     
- Partials         21       23       +2     
Files Coverage Δ
...up4/ticketingservice/controller/EventController.kt 100.00% <ø> (ø)
...lin/com/group4/ticketingservice/dto/ResponseDTO.kt 100.00% <100.00%> (ø)
...om/group4/ticketingservice/service/EventService.kt 100.00% <100.00%> (ø)
...om/group4/ticketingservice/utils/ResponseAdvice.kt 54.02% <100.00%> (-17.57%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junha-ahn junha-ahn linked an issue Oct 16, 2023 that may be closed by this pull request
@junha-ahn junha-ahn merged commit 9eca9e6 into main Oct 16, 2023
9 of 10 checks passed
@junha-ahn junha-ahn deleted the feat/113-remove-total-count branch October 16, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Response 페이지네이션 totalElements 반환 방식 논의
2 participants