Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/137 event caching #141

Merged
merged 11 commits into from
Nov 13, 2023
Merged

Feat/137 event caching #141

merged 11 commits into from
Nov 13, 2023

Conversation

minjun3021
Copy link
Collaborator

What is this PR?

Key Changes

Test Checklist

Copy link
Member

@junha-ahn junha-ahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

캐싱 관련 테스트 구현 부탁드려요.

Integration이여도 상관없습니다.

API Controller 조회 후 캐시 스토리지 조회하는 등..

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (38304fe) 81.69% compared to head (86ff69a) 80.86%.
Report is 1 commits behind head on main.

❗ Current head 86ff69a differs from pull request most recent head f1bd284. Consider uploading reports for the commit f1bd284 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #141      +/-   ##
============================================
- Coverage     81.69%   80.86%   -0.84%     
  Complexity      142      142              
============================================
  Files            43       44       +1     
  Lines           754      763       +9     
  Branches         31       31              
============================================
+ Hits            616      617       +1     
- Misses          115      123       +8     
  Partials         23       23              
Files Coverage Δ
...p4/ticketingservice/TicketingserviceApplication.kt 50.00% <ø> (ø)
...up4/ticketingservice/controller/EventController.kt 100.00% <100.00%> (ø)
.../com/group4/ticketingservice/config/CacheConfig.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junha-ahn junha-ahn merged commit e55633a into main Nov 13, 2023
@junha-ahn junha-ahn deleted the feat/137-event-caching branch November 13, 2023 13:32
@junha-ahn junha-ahn linked an issue Nov 13, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

이벤트 페이지 조회 캐싱
2 participants