[#5] DB연동 및 docker-compose 적용 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lyan
reviewed
Nov 1, 2024
Comment on lines
+20
to
+22
| if (userRepository.findByEmail(user.getEmail()).isPresent()) { | ||
| throw new IllegalArgumentException("이메일 중복"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (userRepository.findByEmail(user.getEmail()).isPresent()) { | |
| throw new IllegalArgumentException("이메일 중복"); | |
| } | |
| Stream.of(user.getEmail()) | |
| .map(userRepository::findByEmail) | |
| .getOrElse(() => throw new IllegalArgumentException("이메일 중복")) | |
| .collect(); |
Suggested change
| if (userRepository.findByEmail(user.getEmail()).isPresent()) { | |
| throw new IllegalArgumentException("이메일 중복"); | |
| } | |
| userRepository | |
| .findByEmail(user.getEmail()) | |
| .getOrElse(() => throw new IllegalArgumentException("이메일 중복")); |
f-lab-lyan
reviewed
Nov 1, 2024
|
|
||
| public LoginResponseDto createUser(SignUpRequestDto request) { | ||
| User user = request.toDomain(); | ||
| if (userRepository.findByEmail(user.getEmail()).isPresent()) { |
There was a problem hiding this comment.
Suggested change
| if (userRepository.findByEmail(user.getEmail()).isPresent()) { | |
| if (userRepository.findByEmail(user.getEmail()) == null) { |
f-lab-lyan
reviewed
Nov 1, 2024
| if (userRepository.findByEmailAndPassword(user.getEmail(), user.getPassword()).isEmpty()) { | ||
| throw new IllegalArgumentException("로그인 정보가 올바르지 않습니다."); | ||
| } | ||
| return LoginResponseDto.of(user, "asdf"); |
There was a problem hiding this comment.
Service에서 DTO를 알고 있는 것이 좋은 것인가요?
f-lab-lyan
reviewed
Nov 1, 2024
| @@ -14,4 +16,8 @@ public class SignUpRequestDto { | |||
| private String email; | |||
| @Schema(description = "사용자 비밀번호") | |||
| private String password; | |||
|
|
|||
| public User toDomain() { | |||
There was a problem hiding this comment.
DTO안에 비지니스 로직이 들어가는 것이 좋은 것인가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해결하려는 문제
변경 사항
참고 사항
CheckList