[33] api 별 유저 권한체크 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ohsuha
commented
Oct 10, 2024
ohsuha
commented
- ROLE_PARTNER : 상품 등록, 수정, 삭제
- ROLE_USER : 장바구니, 배송지, 주문, 결제 등록, 수정, 삭제
- 권한이 필요 없는 API : 상품 리스트, 상품 상세 조회
- 토큰에서 role 체크 - 기존에 request param 으로 받던 partner id 를 토큰에서 파싱하도록 수정
f-lab-kai-c
reviewed
Oct 11, 2024
| var roles = (Map<String, Object>)resourceAccess.get("oauth2-client-app"); | ||
|
|
||
| if (roles != null) { | ||
| log.info(roles.toString()); |
There was a problem hiding this comment.
헉 불필요한 로그입니다. 테스트 하기 위해서 사용했는데 삭제하도록 하겠습니다.
| @@ -50,4 +64,20 @@ public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Excepti | |||
|
|
|||
| return http.build(); | |||
| } | |||
|
|
|||
| private Collection<GrantedAuthority> extractAuthorities(Jwt jwt) { | |||
| var resourceAccess = (Map<String, Object>)jwt.getClaim("resource_access"); | |||
There was a problem hiding this comment.
권한을 jwt에서 받아올 때, 관리 측면에서 신경써줘야 할 부분이 있을까요?
There was a problem hiding this comment.
토큰 만료 시간을 짧게 설정해서 탈취되더라도 오랫동안 사용되지 않게 합니다.
role 이 변경되었는데 기존 발급받은 토큰의 재사용을 막기 위해 api 서버에서 DB 체크를 추가로 합니다
There was a problem hiding this comment.
db 체크를 추가로 하면, 토큰에 role을 집어넣을 필요가 없는거 아닌가요?
|
이 PR도 그렇고 과거 PR들에서 이전 작업 내용이 포함되어 있는 경우가 있는데, 어떻게 개선해볼 수 있을까요? |
ohsuha
changed the base branch from
develop
to
feature/partner/36-create-partner
|
base 를 이전 PR 로 올린 브랜치로 변경 했습니다..! |
ohsuha
changed the base branch from
feature/partner/36-create-partner
to
develop
f-lab-kai-c
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.