Feature/12 : 구매 완료 상품, 판매 완료 상품 조회 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mason136
reviewed
Oct 17, 2024
| return ApiResponse.success(auctionService.getBuyHistory(userId.toLong())) | ||
| } | ||
|
|
||
| @GetMapping("{id}/sold") | ||
| fun getSoldAuctionDetail(@RequestParam userId: String, @PathVariable id: Long): ApiResponse<SellAuctionDetailDto> { |
There was a problem hiding this comment.
id보단 auctionId로 명시적으로 쓰는게 더 좋아보이네요
mason136
reviewed
Oct 17, 2024
| } | ||
|
|
||
| fun getBoughtAuctionDetail(userId: Long, auctionId: Long): BuyAuctionDetailDto { | ||
| val auction = auctionRepository.findById(auctionId) |
There was a problem hiding this comment.
getSoldAuctionDetail와 중복된 조회 로직은 줄여보시죠
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)