Feature/8 : 이미지 추가 및 수정 #22
Open
+794
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mason136
reviewed
Oct 22, 2024
| class UnAuthorizationException : RuntimeException() | ||
|
|
||
| class UnsupportedFileExtensionException : RuntimeException() |
There was a problem hiding this comment.
예외가 발생할 때마다 클래스를 만들 수 없으니 응답 코드, 메세지를 받는 예외 클래스를 만들어보시죠
| fileNames.forEach { delete(it) } | ||
| } | ||
|
|
||
| fun delete(fileName: String) { |
| throw UnsupportedFileExtensionException() | ||
| } | ||
| val extension = fileName.substring(extensionIndex + 1) | ||
| require(IMAGE_EXTENSIONS.contains(extension)) { |
There was a problem hiding this comment.
확장자가 대문자로 오는 경우도 예외 발생 안하게 해주세요
| @Convert(converter = ProductImagesConverter::class) | ||
| @Column(name = "IMAGES") | ||
| val images: ProductImagesVo, | ||
| @Convert(converter = ProductImagesConverter::class) @Column(name = "IMAGES") val images: ProductImagesVo, |
| @Id @GeneratedValue(strategy = GenerationType.IDENTITY) var id: Long = 0L, | ||
| ) : AuditingTimeEntity() { | ||
| fun updateProduct(dto: ProductEditReq): Product { |
|
|
||
| companion object { | ||
| fun validateProduct(startPrice: Int, startDate: LocalDateTime, endDate: LocalDateTime) { |
There was a problem hiding this comment.
이 로직이 static 함수로 명시가 되있는게 이상합니다.
kotlin에 init을 활용해 Product 생성시 검증을 진행하는게 더 적합하빈다.
| } | ||
|
|
||
| private fun validateStartPrice(startPrice: Int) { |
There was a problem hiding this comment.
마찬가지로 static 함수로 명시된게 이상합니다.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)