-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SkeletonDiv component #35
base: develop
Are you sure you want to change the base?
Conversation
dev-khs
commented
Oct 27, 2024
- 스켈레톤 UI를 적용한 컨테이너 컴포넌트를 추가합니다.
Deploying khs-log with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
전반적으로 코드를 잘 작성해 주셨네요 ㅎㅎ 컨벤션을 잘 잡아주시는 코드가 많아 보였던 것 같습니다.
React.useState와 useState 이렇게 두 가지 방식으로 import 하는 것이 크게 차이는 없지만, tree-shaking 관점에서 약간의 차이가 있는데요. 모듈을 어떻게 불러오는게 더 효울적인지 방식을 고민해 보시는 것도 의미가 있을 것 같습니다.
interface Props extends HTMLAttributes<HTMLDivElement> { | ||
isLoading: boolean | ||
children?: ReactNode | ||
className?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isLoading 인 경우와 아닌 경우 className을 다르게 받아야 할 경우는 발생하지 않나요?
Quality Gate passedIssues Measures |