Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SkeletonDiv component #35

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

feat: add SkeletonDiv component #35

wants to merge 4 commits into from

Conversation

dev-khs
Copy link
Collaborator

@dev-khs dev-khs commented Oct 27, 2024

  • 스켈레톤 UI를 적용한 컨테이너 컴포넌트를 추가합니다.

@dev-khs dev-khs added enhancement New feature or request UX/UI Improves UX/UI design or style elements feat Implement new features or components labels Oct 27, 2024
@dev-khs dev-khs self-assigned this Oct 27, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 27, 2024

Deploying khs-log with  Cloudflare Pages  Cloudflare Pages

Latest commit: b989a80
Status: ✅  Deploy successful!
Preview URL: https://48d867e6.khs-log.pages.dev
Branch Preview URL: https://feat-skeleton-ui.khs-log.pages.dev

View logs

Copy link

@f-lab-joshua f-lab-joshua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

전반적으로 코드를 잘 작성해 주셨네요 ㅎㅎ 컨벤션을 잘 잡아주시는 코드가 많아 보였던 것 같습니다.

React.useState와 useState 이렇게 두 가지 방식으로 import 하는 것이 크게 차이는 없지만, tree-shaking 관점에서 약간의 차이가 있는데요. 모듈을 어떻게 불러오는게 더 효울적인지 방식을 고민해 보시는 것도 의미가 있을 것 같습니다.

interface Props extends HTMLAttributes<HTMLDivElement> {
isLoading: boolean
children?: ReactNode
className?: string

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isLoading 인 경우와 아닌 경우 className을 다르게 받아야 할 경우는 발생하지 않나요?

@dev-khs dev-khs marked this pull request as draft November 1, 2024 11:50
Copy link

sonarcloud bot commented Nov 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feat Implement new features or components UX/UI Improves UX/UI design or style elements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants