Feature/member #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CookieUtil cookieUtil; | ||
| TokenUtil tokenUtil; | ||
| SignUpUseCase signupUseCase; | ||
| LoginUseCase loginUseCase; |
There was a problem hiding this comment.
UseCase 가 직관적인 네이밍은 아닌거 같습니다.
계층 구조를 만들고자 한다면 Processor 나 Application 이 좋을 것 같습니다.
판단해주시면 좋을 것 같습니다.
There was a problem hiding this comment.
이 부분은 일단 UseCase로 유지해서 사용해보도록 하겠습니다
|
|
||
| ResponseCookie responseCookie = createLoginTokenCookie(member); | ||
|
|
||
| response.addHeader("Set-Cookie", responseCookie.toString()); |
There was a problem hiding this comment.
ResponseDto를 사용해서 반환하도록 수정했습니다!
| } | ||
|
|
||
| public Member create(CreateMemberDto createDto) { | ||
| return memberRepository.save(createDto.toModel(encodePassword(createDto.password()))); |
There was a problem hiding this comment.
salt를 포함해서 비밀번호 암호화 로직 수정했습니다!
| import org.springframework.web.bind.annotation.ResponseStatus; | ||
|
|
||
| @ResponseStatus(value = HttpStatus.UNAUTHORIZED) | ||
| public class UnAuthorized extends CustomException { |
There was a problem hiding this comment.
예외 클래스명을 전부 ~Exception으로 수정햇습니다!
| import org.springframework.web.bind.annotation.ResponseStatus; | ||
|
|
||
| @ResponseStatus(value = HttpStatus.CONFLICT) | ||
| public class ConflicException extends CustomException { |
jinspark-lab
approved these changes
Aug 25, 2024
넵! 회원관리 부분은 간단하게 구현하기 위해서 핸드포번호 변경등은 고려하지 않았습니다! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
회원 관련 기능 개발
상세정보