콘서트 좌석정보 수정, 콘서트 상태 close로 변경 API 개발 및 콘서트 상태 open 변경 스케줄러 작업 추가 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| } | ||
|
|
||
| @PutMapping("/{id}/state/close") |
| @@ -141,4 +145,43 @@ public Concert updatePlace(Place place, List<ConcertSeat> seats) { | |||
| .seats(List.copyOf(seats)) | |||
| .build(); | |||
| } | |||
|
|
|||
| public Concert changeState(ConcertState state) { | |||
There was a problem hiding this comment.
메서드명이 changeState 인데 실제로는 get 을 수행하는것 같습니다.
| getListVo.name() != null ? concertEntity.name.contains(getListVo.name()) : null, | ||
| getListVo.placeName() != null ? placeEntity.name.contains(getListVo.name()) : null, | ||
| getListVo.state() != null ? concertEntity.state.eq(getListVo.state()) : null, | ||
| getListVo.openTime() != null ? concertEntity.openTime.loe(getListVo.openTime()) : null |
There was a problem hiding this comment.
loe 보다는 임의의 시간을 줘서 between 으로 하시는게 좋습니다.
|
|
||
| public List<ConcertEntity> getList(GetConcertListVo getListVo) { | ||
| return selectFrom(concertEntity) | ||
| .leftJoin(concertEntity.placeEntity, placeEntity) |
There was a problem hiding this comment.
leftJoin 은 성능 저하가 커서 케이스에 따라 나누는 걸 추천드립니다.
|
jinspark-lab
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.