Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an interaction api #1687

Merged
merged 16 commits into from
Nov 12, 2024
Merged

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Nov 3, 2024

Add an API to let libf3d users control how interactions are handled

  • Add interactor::addInteractionCommand, interactor::removeInteractorCommand
  • Use it in interactor_impl to declare all libf3d interactions
  • Use it in F3DStarter to to declare all F3D interactions
  • Remove interactor::setKeyPressCallBack
  • Implement the interaction command logic in OnKeyPress
  • Update TestSDKInteractorCallback accordingly
  • Add libf3d doc
  • Add python bindings and tests

To do later:

Copy link

github-actions bot commented Nov 3, 2024

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (15d0b19) to head (86942db).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1687      +/-   ##
==========================================
- Coverage   96.98%   96.96%   -0.02%     
==========================================
  Files         106      106              
  Lines        8781     8733      -48     
==========================================
- Hits         8516     8468      -48     
  Misses        265      265              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal force-pushed the add_interaction_api branch 2 times, most recently from 5aac206 to b7f3d6e Compare November 7, 2024 19:52
@mwestphal mwestphal changed the title [draft] Add interaction api Add an interaction api Nov 7, 2024
@mwestphal mwestphal requested a review from Meakk November 8, 2024 07:01
library/public/interactor.h Show resolved Hide resolved
library/public/interactor.h Show resolved Hide resolved
library/public/interactor.h Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
@mwestphal mwestphal requested a review from Meakk November 9, 2024 12:40
mwestphal and others added 2 commits November 9, 2024 16:10
Co-authored-by: snoyer <noyer.stephane@gmail.com>
Co-authored-by: snoyer <noyer.stephane@gmail.com>
library/public/interactor.h Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
(cherry picked from commit da368eb)
application/F3DStarter.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
python/F3DPythonBindings.cxx Outdated Show resolved Hide resolved
@mwestphal mwestphal requested a review from Meakk November 11, 2024 20:47
@mwestphal mwestphal merged commit 183be71 into f3d-app:master Nov 12, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants