Solid: Fix config spread

f5 · Oct 29, 2024 · d3dbb91 · d3dbb91
1 parent be0e9d8
commit d3dbb91
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/solid/src/containers/single-container/index.tsx b/packages/solid/src/containers/single-container/index.tsx
@@ -36,7 +36,6 @@ export function VisSingleContainer<Datum>(
     component: undefined,
     annotations: undefined,
     tooltip: undefined,
-    ...rest,
   })
   const [track, dirty] = createTrigger()
 
@@ -64,7 +63,7 @@ export function VisSingleContainer<Datum>(
     init()
     // track the changes
     track()
-    chart()?.updateContainer(config)
+    chart()?.updateContainer({...config, ...rest})
   })
 
   const update: VisContainerContextProps['update'] = (key, value) => {

diff --git a/packages/solid/src/containers/xy-container/index.tsx b/packages/solid/src/containers/xy-container/index.tsx
@@ -44,7 +44,6 @@ export function VisXYContainer<Datum>(props: VisXYContainerProps<Datum>) {
     tooltip: undefined,
     xAxis: undefined,
     yAxis: undefined,
-    ...rest,
   })
   const [track, dirty] = createTrigger()
 
@@ -67,7 +66,7 @@ export function VisXYContainer<Datum>(props: VisXYContainerProps<Datum>) {
   createEffect(() => {
     // track the changes
     track()
-    chart()?.updateContainer(config)
+    chart()?.updateContainer({...config, ...rest})
   })
 
   const update: VisContainerContextProps['update'] = (key, value) => {