-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website | Add new composite chart section and dual axis chart #383
Conversation
@lee00678 Great, thanks! I think we should add to the description some brief text and references about pros and cons of using dual axis charts. Datawrapper has a great blog post on the subject: https://blog.datawrapper.de/dualaxis/ |
Also, I don't really like the style of the chart I created (I think there's too much red), but maybe it will help scare people away from using two-axis charts 😄 |
I'm happy to change it to bright orange 🔶 to make it more scary. Flip blue and red? |
@lee00678 Yes, let's just flip them, thanks! |
I added the following description, honestly I don't think there are much
|
@lee00678 Nice, I like it, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for the reviews! |
I ported over the one example in dev. Used generated data. Since it's pretty controversial in terms of whether/when people should use it, I figure we simply demo the way to do it, so users know it's a possibility.