Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in custom SVG defs for Containers in Versions > 1.4.1 #440

Open
flschweiger opened this issue Sep 3, 2024 · 3 comments
Open

Comments

@flschweiger
Copy link

It seems that using custom SVG defs with containers stopped functioning properly in versions later than 1.4.1. For instance, applying custom SVGs as colors for a StackedBar within an XY container no longer renders as expected.

Upon comparing versions 1.4.1 and 1.4.2, I noticed changes in the implementation within packages/ts/src/core/container/index.ts. A quick review suggests that these custom SVGs might not be added to the svg element anymore.

I'll try to investigate this issue further when I get a chance, but I wanted to bring it to your attention in the meantime 🙂

Thanks for maintaining such a great library!

@rokotyan
Copy link
Contributor

rokotyan commented Sep 3, 2024

@flschweiger Thank you for reporting the issue! Can you please show us how you have set up your chart? I have not been able to reproduce the problem with my configuration.

@stevenhurth
Copy link

I've found that if I specify the svg def in the template html (vue 3), it will work. However, using the svgDefs prop does not work.

@rokotyan
Copy link
Contributor

@stevenhurth Can you please confirm that you're using the latest @unovis/ts and @unovis/vue versions (1.4.4)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants