Core | Container: Improve ResizeObserver handling #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use requestAnimationFrame to avoid multiple resize events when scrollbars appear/disappear - Cancel previous animation frame IDs before scheduling new ones - Renamed `_requestedAnimationFrame` to `_renderAnimationFrameId` Fixes f5#455
|
@rokotyan how so I test this? I removed Screen.Recording.2024-10-21.at.3.33.57.AM.mov |
- Adds a new example for a full height donut chart - Tests the resize behavior of the donut chart component f5#455
|
@lee00678 I've pushed a new example for this |
Thanks for the clarification. |
lee00678
approved these changes
Oct 21, 2024
|
Hooray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #455, a problem with ResizeObserver throwing an error when scrollbars appear/disappear. Solving this by delaying the resize by one frame.
The only tradeoff is scrollbar flickering when changing the size, but it only appears when "Show scroll bars" setting is set to "Always" on macOS (not sure about the other platforms).
Screen.Recording.2024-10-11.at.3.18.15.PM.mp4
Changelog:
_requestedAnimationFrameto_renderAnimationFrameId