Component | Graph: SVGs in Link labels, Zoom start/end callbacks, Fit view to specific nodes, Docs update #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for internal links Render link labels as SVG `use` elements when the label text is an id pointing to the element provided via `svgDefs` to the container. This allows the link labels to use SVG icons instead of simple text
Consolidate utility exports in `packages/ts/src/index.ts` by creating a new `utils/index.ts` file that re-exports all utility modules. This simplifies the main entry point and makes it easier to discover and use the available utility functions.
- Ensures the `fitView` method waits for the `_layoutCalculationPromise` to resolve before calling `_fit` to prevent potential errors.
- Adds `onZoomStart` and `onZoomEnd` callbacks to the `GraphConfigInterface` to allow users to hook into the start and end of the zoom behavior. - Implements the `_onZoomStart` and `_onZoomEnd` methods to call the respective callbacks when the zoom behavior starts and ends.
- Adds an optional `nodeIds` parameter to the `fitView` method that allows the caller to specify which nodes to fit the view to. - Updates the `_fit` method to filter the nodes to the specified `nodeIds` if provided, or use all nodes if not. - This enables users to focus the view on a subset of nodes, rather than always fitting the entire graph.
lee00678
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few news features to the graph component and updates the documentation (covering the previous updates too).
SVGs in Link labels
Screen.Recording.2024-10-17.at.3.15.34.PM.mov
Fit View to specific nodes
Screen.Recording.2024-10-17.at.3.17.20.PM.mp4
New Zoom callbacks
Docs update
Screen.Recording.2024-10-17.at.3.18.42.PM.mp4