ecs run: InvalidParameterException thrown when running a task definition using awsvpc + EC2 launch type

[jkcdarunday]

Hi,

I get the following when I try to use the run command on a task that use the EC2 launch type and awsvpc as the network mode:

% ecs run staging projects -c projects "npm run initdb"                                                                                                                                                                                                                      
Using task definition: projects
Changed command of container "projects" to: "npm run initdb" (was: "[]")

An error occurred (InvalidParameterException) when calling the RunTask operation: Network Configuration must be provided when networkMode 'awsvpc' is specified.

Notes:

• A service that can scale is already running using the same task definition so it should be correct and there shouldn't be an issue with having two tasks with the same configuration.
• ecs run ... does not work with Fargate #61 might be related, however, that issue is with using Fargate. Mine uses EC2 with awsvpc instead.

[jkcdarunday]

Tried to do this in the AWS web interface. It seems that VPC, security group, and subnet are required even though I'm running with EC2.

I was able to successfully run a task with a command override using the web interface.

[fabfuel]

Hi @jkcdarunday,

when running a task in network mode "awsvpc", you have to provide the subnet and the security group - like you do in the web (in your screenshot). You can provide those in the call with:

• --subnet
• --securitygroup

All details and options you can see via ecs run --help.

Best
Fabian

[jkcdarunday]

Hi @fabfuel
I have tried that as well. However, it did not seem to work and threw the same error.

% ecs run staging projects -c projects "npm run initdb" --launch-type EC2  --securitygroup sg-xxxxxxxxx --subnet subnet-xxxxxxxxx                                                           
Using task definition: projects
Changed command of container "projects" to: "npm run initdb" (was: "[]")

An error occurred (InvalidParameterException) when calling the RunTask operation: Network Configuration must be provided when networkMode 'awsvpc' is specified.

[jkcdarunday]

Looking at the code, it seems that no networkConfiguration value is being passed if the launch type is EC2 (it is only added on Fargate).

Perhaps networkConfiguration should be passed for the EC2 launch type as well as EC2 also supports awsvpc?

ecs-deploy/ecs_deploy/ecs.py

Lines 93 to 124 in fe7447a

	if launchtype == LAUNCH_TYPE_FARGATE:
	if not subnets or not security_groups:
	msg = 'At least one subnet (--subnet) and one security ' \
	'group (--securitygroup) definition are required ' \
	'for launch type FARGATE'
	raise TaskPlacementError(msg)
	network_configuration = {
	"awsvpcConfiguration": {
	"subnets": subnets,
	"securityGroups": security_groups,
	"assignPublicIp": "ENABLED" if public_ip else "DISABLED"
	}
	}
	return self.boto.run_task(
	cluster=cluster,
	taskDefinition=task_definition,
	count=count,
	startedBy=started_by,
	overrides=overrides,
	launchType=launchtype,
	networkConfiguration=network_configuration
	)
	return self.boto.run_task(
	cluster=cluster,
	taskDefinition=task_definition,
	count=count,
	startedBy=started_by,
	overrides=overrides
	)

[fabfuel]

Indeed, you're right

[jkcdarunday]

I have tried to edit the code to always pass networkConfiguration regardless of launch type and it seems to be working with my fork's commit at jkcdarunday@6e8ee0d

Should I do a pull request? I am not sure if specifying an awsvpcConfiguration affects task definitions that don't use awsvpc though as all of my services currently use awsvpc.

% python ecs_deploy/cli.py run staging projects -c projects "npm run initdb"  --securitygroup sg-xxxxxxxx --subnet subnet-xxxxxxxx
Using task definition: projects
Changed command of container "projects" to: "npm run initdb" (was: "[]")

Successfully started 1 instances of task: projects:4
- arn:aws:ecs:ap-southeast-1:xxxxxxxxx:task/staging/xxxxx

[fabfuel]

Thanks @jkcdarunday, I think the safes way is to add a new argument for the network mode and to require and add the network config to the task definition only, if it is set to awsvpc.

Best
Fabian