From f959c4cae53d2af1a5d05c6256ecc0b2e33b7545 Mon Sep 17 00:00:00 2001 From: erysdren Date: Fri, 12 Apr 2024 05:02:28 -0500 Subject: [PATCH 1/2] Fix cinematics off-by-one-pixel draw error --- rott/cin_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rott/cin_main.c b/rott/cin_main.c index 87035a7..e6d1825 100644 --- a/rott/cin_main.c +++ b/rott/cin_main.c @@ -247,8 +247,9 @@ void R_DrawFilmColumn (byte * buf) int frac, fracstep; byte *dest; - count = cin_yh - cin_yl; - if (count < 0) return; + count = (cin_yh + 1) - cin_yl; + if (!count) + return; dest = buf + ylookup[cin_yl]; From 1a5366c81456b4aea7a275af6bfe7400ce1058ec Mon Sep 17 00:00:00 2001 From: erysdren Date: Fri, 12 Apr 2024 05:45:18 -0500 Subject: [PATCH 2/2] cin_main.c: Match semantics of R_DrawColumn() --- rott/cin_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/rott/cin_main.c b/rott/cin_main.c index e6d1825..b130477 100644 --- a/rott/cin_main.c +++ b/rott/cin_main.c @@ -247,9 +247,8 @@ void R_DrawFilmColumn (byte * buf) int frac, fracstep; byte *dest; - count = (cin_yh + 1) - cin_yl; - if (!count) - return; + count = cin_yh - cin_yl + 1; + if (count < 0) return; dest = buf + ylookup[cin_yl];