Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull ROTT data from various common install paths #72

Merged
merged 9 commits into from
Jul 15, 2024
Merged

Conversation

erysdren
Copy link
Collaborator

@erysdren erysdren commented Jul 6, 2024

Heavily work in progress. It builds under Mingw, but it doesn't do any (much needed) Windows Registry checks for things such as the Steam directory and maybe others. For both Linux and Windows, it just queries the default installation paths from the various storefronts for each platform. It works, but it's not super elegant or foolproof. This does not conflict with the XDG paths or any others.

This also needs to be modified to account for where the game could be installed with GOG under Mac OS X.

@erysdren erysdren requested a review from fabiangreffrath July 8, 2024 16:52
@erysdren
Copy link
Collaborator Author

erysdren commented Jul 9, 2024

This actually causes a segfault in the COMM-BAT menu because it tries to display the filename of the RTC mapset. It uses the full filepath in a buffer of 80 chars which is not long enough for most of these.

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erysdren erysdren marked this pull request as ready for review July 14, 2024 07:02
@fabiangreffrath
Copy link
Owner

Heavily work in progress. It builds under Mingw, but it doesn't do any (much needed) Windows Registry checks for things such as the Steam directory and maybe others.

Do you plan to add that later?

@erysdren
Copy link
Collaborator Author

I do. I will likely import the appropriate code from Ironwail with the appropriate attribution, if possible.

@erysdren
Copy link
Collaborator Author

@fabiangreffrath Does this need any more work before merging?

@fabiangreffrath
Copy link
Owner

Not if you want to postpone the windows registry checks.

@erysdren
Copy link
Collaborator Author

I will add those as a separate PR later. Thank you!

@erysdren erysdren merged commit aba5817 into main Jul 15, 2024
4 checks passed
@erysdren erysdren deleted the storefronts branch July 15, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants