-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull ROTT data from various common install paths #72
Conversation
This actually causes a segfault in the COMM-BAT menu because it tries to display the filename of the RTC mapset. It uses the full filepath in a buffer of 80 chars which is not long enough for most of these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Do you plan to add that later? |
I do. I will likely import the appropriate code from Ironwail with the appropriate attribution, if possible. |
@fabiangreffrath Does this need any more work before merging? |
Not if you want to postpone the windows registry checks. |
I will add those as a separate PR later. Thank you! |
Heavily work in progress. It builds under Mingw, but it doesn't do any (much needed) Windows Registry checks for things such as the Steam directory and maybe others. For both Linux and Windows, it just queries the default installation paths from the various storefronts for each platform. It works, but it's not super elegant or foolproof. This does not conflict with the XDG paths or any others.
This also needs to be modified to account for where the game could be installed with GOG under Mac OS X.