Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove execinfo dependency and old crash_print handler #84

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

erysdren
Copy link
Collaborator

Yamagi Quake II is also licensed under GNU GPL v2, so this should be okay to do. This allows us to use the backtrace function in a more portable way, instead of stacking up ifdef's.

@fabiangreffrath
Copy link
Owner

Honestly, I'm not sure if we need this code at all. We can use gdb nowadays if we need a backtrace.

@erysdren
Copy link
Collaborator Author

I'm fine with removing it.

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, thank you! Please remember to adjust the PR title before merging.

@erysdren erysdren changed the title Use execinfo/backtrace lookup from Yamagi Quake II Remove execinfo dependency and old crash_print handler Aug 26, 2024
@erysdren erysdren merged commit dbf4eed into main Aug 26, 2024
4 checks passed
@erysdren erysdren deleted the execinfo branch August 26, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants